On Wed, 27 Nov 2024 15:40:22 GMT, Ivan Bereziuk <d...@openjdk.org> wrote:
>> The output for Jtreg v7.5 was >> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) >> with [information about skipped >> tests](https://github.com/openjdk/jtreg/blob/master/src/share/doc/javatest/regtest/faq.md#what-do-all-those-numbers-in-the-test-results-line-mean). >> >> Use the additional information in the "summary" block printed at the end of >> `make test` target. > > Ivan Bereziuk has updated the pull request incrementally with one additional > commit since the last revision: > > remove resorting zero-ing of $1_SKIPPED as preceding gawk always assigns > the value make/RunTests.gmk line 1042: > 1040: # In jtreg, "skipped:" category accounts for tests that threw > jtreg.SkippedException at runtime. > 1041: # At the same time these tests contribute to "passed:" tests. > 1042: # In here we don't want that and so we substract number of "skipped:" > from "passed:". Can you please indent this to the level of the recipe line below (using space and not tab, see (5) in https://openjdk.org/groups/build/doc/code-conventions.html). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22245#discussion_r1866009712
