On Sat, 14 Jun 2008, Bernhard Fischer wrote: > On Sat, Jun 14, 2008 at 09:20:08PM +0200, Cristian Ionescu-Idbohrn wrote: > >--- networking/udhcp/dhcpc.c.~1~ 2008-06-14 19:37:37.000000000 +0200 > >+++ networking/udhcp/dhcpc.c 2008-06-14 20:24:20.000000000 +0200 > >@@ -201,40 +197,26 @@ > > OPT_f = 1 << 20, > > /* The rest has variable bit positions, need to be clever */ > -> OPTBIT_f = 20, > + OPTBIT_f = 20 > > ->+ USE_FOR_MMU(OPTBIT_b,) > ->+ USE_FEATURE_UDHCPC_ARPING(OPTBIT_a,) > ->+ USE_FEATURE_UDHCP_PORT(OPTBIT_P,) > ->+ USE_FOR_MMU(OPT_b = 1 << OPTBIT_b,) > ->+ USE_FEATURE_UDHCPC_ARPING(OPT_a = 1 << OPTBIT_a,) > ->+ USE_FEATURE_UDHCP_PORT(OPT_P = 1 << OPTBIT_P,) > + USE_FOR_MMU(,OPTBIT_b) > + USE_FEATURE_UDHCPC_ARPING(,OPTBIT_a) > + USE_FEATURE_UDHCP_PORT(,OPTBIT_P) > + USE_FOR_MMU(,OPT_b = 1 << OPTBIT_b) > + USE_FEATURE_UDHCPC_ARPING(,OPT_a = 1 << OPTBIT_a) > + USE_FEATURE_UDHCP_PORT(,OPT_P = 1 << OPTBIT_P) > > > };
Right. I see your point. And there's more that could be done to cleanup insane amount of ifdefs. But the first measure should be to move all such macros to header files in a consistant way. Thoughts? Cheers, -- Cristian _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
