On Saturday 14 June 2008 21:20, Cristian Ionescu-Idbohrn wrote: > Shouldn't this: > > USE_FEATURE_UDHCPC_ARPING(OPTBIT_a,) > > be prefered, instead of this: > > #if ENABLE_FEATURE_UDHCPC_ARPING > OPTBIT_a, > #endif
Yes, generally, if USE_xxx(foo) doesn't stretch across more than one line. That looks worse (less readable) than ifdef. > The attchment shows how networking/udhcp/dhcpc.c may be changed. Applied, thanks! -- vda _______________________________________________ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox
