On Sun, 15 Jun 2008, Denys Vlasenko wrote: > On Sunday 15 June 2008 16:48, Cristian Ionescu-Idbohrn wrote: > > On Sun, 15 Jun 2008, Bernhard Fischer wrote: > > > > > >> USE_IF_FEATURE_X and SKIP_IF_FEATURE_X would be better. > > > > > > I don't think explicitely adding the implied "_IF" buys anything. > > > > True. Costs 3 extra characters, but makes more obvious what the macro is > > supposed to do. > > SKIP_IF_x is wrong. USE_IF_NOT_x! To see it, pick real examples: > > ... > USE_IF_ARPING(int x = y;) > SKIP_IF_ARPING(const int x = 5;) <==== ?!! > ... > > ... > USE_IF_ARPING(int x = y;) > USE_IF_NOT_ARPING(const int x = 5;) > ...
I'm all with you :) Cheers, -- Cristian _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
