Bernhard Fischer wrote: > > > I don't think explicitely adding the implied "_IF" buys anything. >> assume that: >> skip = ! use >> >> that means you can write: >> USE_IF_FEATURE(!x) > no, you cannot. Think about e.g.: > > /* If not blah, then we have to foo */ > SKIP_FEATURE_BLAH(unsigned foo_stuff);
this was symbolic. you can also think of IF_FOO_ENABLED( ... ) IF_NOT_FOO_ENABLED( ... ) > a '!' doesn't help there. >> that would reduce the number of macros by one (type). >> >> ntl: your point is correct, we have way to many macros > > I disagree. There is USE_ and SKIP_ that use varargs. For bigger blocks > or where it is more readable, there is ENABLE and !ENABLE grep -ir "#define" * | wc -l 8977 of cause this is only an upper limit but we should ask our self "do we need that ???" i know no every #define is a macro in the sense use above > I propose you look at TODO instead and pick a random item to take care > of. That would IMHO make more sense :) this is correct but open source is about "scratching an itch" and if vda does not like it changes will not be accepted. NTL introducing different names for thinks that do actualy the same is not very clever an will only lead to confusion. just my 2 cents, walter _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
