Hey Dave, * Dave Miner (dave.mi...@oracle.com) wrote: > Caimaniacs, > > I need reviewers for the webrev at > > http://cr.opensolaris.org/~dminer/slim_6973927/ > > which encompasses fixes for the following issues: > > 6973927 Installation fails if Primary Administrator rights profile > is removed from the system > 4885 User created by installer gets unsafe profile "Primary Administrator" > 9966 install unnecessarily propagates /lost+found from image to rpool > 15454 pkg install failure in im_pop did not abort DC and AI > 16295 install-finish runs update_boot_archive ICT twice for text and > GUI installs > 16645 Incorrect permissions on ict.py in build 144 can cause ict's > to fail to run > 16740 Special handling of SUNWcs and SUNWcsd can be removed from > transfer module
Looks good overall, just some nits. boot_archive_archive.py: Nit - spelling nit isn't a valid check-in comment ;-) svc-system-config: ln 399, 666-675: indentation is off system-config.xml: ln 100: indentation is off ict.py: ln 354-355,475-476,2467-2468,2536-2612: indentation is off transfer_mod.py: 1216,1233,1235-1236: indentation is off 1242: unnecessary extra line Glenn _______________________________________________ caiman-discuss mailing list caiman-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/caiman-discuss