* Dave Miner (dave.mi...@oracle.com) wrote: > On 08/11/10 01:02 PM, Glenn Lagasse wrote: > >Hey Dave, > > > >* Dave Miner (dave.mi...@oracle.com) wrote: > >>Caimaniacs, > >> > >>I need reviewers for the webrev at > >> > >>http://cr.opensolaris.org/~dminer/slim_6973927/ > >> > >>which encompasses fixes for the following issues: > >> > >>6973927 Installation fails if Primary Administrator rights profile > >>is removed from the system > >>4885 User created by installer gets unsafe profile "Primary Administrator" > >>9966 install unnecessarily propagates /lost+found from image to rpool > >>15454 pkg install failure in im_pop did not abort DC and AI > >>16295 install-finish runs update_boot_archive ICT twice for text and > >>GUI installs > >>16645 Incorrect permissions on ict.py in build 144 can cause ict's > >>to fail to run > >>16740 Special handling of SUNWcs and SUNWcsd can be removed from > >>transfer module > > > >Looks good overall, just some nits. > > > >boot_archive_archive.py: > > > >Nit - spelling nit isn't a valid check-in comment ;-) > > > > Will be gone when I recommit prior to push. > > >svc-system-config: > > > >ln 399, 666-675: indentation is off > > > >system-config.xml: > > > >ln 100: indentation is off > > > > Both of the above files are fine in my checking.
Odd. They don't display fine for me in the webrev on firefox. If you've checked them (and the others mentioned) and they're fine in the source then I'm fine with chalking it up to a local firefox display issue on my end. Thanks Dave, Glenn _______________________________________________ caiman-discuss mailing list caiman-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
