Hi Dave,
A number of annoying bugs that I'm quite happy to see fixed.
I just have a few nits and one non-nit:
all_lang_slim_cd_x86.xml didn't get an updated comment on why the
post_install_remove was needed.
slim_cd_x86.xml probably also needs one.
ict.py:
193: (The only non-nit) I think the range should be 256 now, based on my
recent blunder...
364-372, 2452: PEP8 - no spaces around '=' in keyword args.
2559: -> elif "type=role;" in l:
transfer_mod.py:
1226, 1239: Pre-existing, but that's an odd blend of string formatting
and concatenation.
1227: pkgs.rstrip() would be preferred.
1210, 1212, 1216: Completely optional - could properly build "cmd" up as
a list to begin with rather than repeated string manipulations. Would
also avoid potential issues from readlines() not stripping off trailing
newlines (by forcing explicit removal, perhaps by having line 1210 be
"pkgs = pkgfile.read().splitlines()")
Thanks,
Keith
On 08/11/10 09:16 AM, Dave Miner wrote:
Caimaniacs,
I need reviewers for the webrev at
http://cr.opensolaris.org/~dminer/slim_6973927/
which encompasses fixes for the following issues:
6973927 Installation fails if Primary Administrator rights profile is
removed from the system
4885 User created by installer gets unsafe profile "Primary
Administrator"
9966 install unnecessarily propagates /lost+found from image to rpool
15454 pkg install failure in im_pop did not abort DC and AI
16295 install-finish runs update_boot_archive ICT twice for text and
GUI installs
16645 Incorrect permissions on ict.py in build 144 can cause ict's to
fail to run
16740 Special handling of SUNWcs and SUNWcsd can be removed from
transfer module
Dave
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
