[3] usr/src/cmd/distro_const/checkpoints/pre_pkg_img_mod.py
line 200: Should you be unsetting the new LD_LIBRARY_PATH?
line 303: shame on you ;-)
usr/src/cmd/distro_const/checkpoints/boot_archive_configure.py
line 111: Is read the default here? Might be nice to specify for
readability.
line 150: s/createing/creating/
line 233: I don't understand why you have path here and then join it
with subdir which seams to just yield subdir.
line 303,352,448: Do we not want to use dry_run for DC?
line 416: I'm not familiar with this .conf file, is there potentially
more than one daemon line?
usr/src/cmd/distro_const/checkpoints/boot_archive_archive.py
Line 120: you do a chdir(directory). Where do you chdir back?
line 245,250,253,401: Just a heads up that with the transfer
restructuring we talked about these lines will change. I'll work with
you on it.
lines 268-271: If we're just throwing away the nbpi that was calculated
in calculate_ba_size why bother? Would it make sense to set self.nbpi
from the code that calculates nbpi if it hasn't been passed in so that
this if goes away? This is kind of a nit though.
line 300: Although I like this message I suspect it should go, or at
least the HEY's.
line 334: you chdir here, do you need to chdir back?
line 444: You never do anything with dry_run. Is that on purpose?
usr/src/cmd/distro_const/checkpoints/test/test_pre_pkg_img_mod.py
What coverage did you get?
Doc strings would be nice.
line 82: Yeah, verification would be nice. This test always passes, right?
usr/src/cmd/distro_const/checkpoints/test/test_boot_archive_configure.py
What coverage did you get?
Doc strings would be nice.
usr/src/cmd/distro_const/checkpoints/test/test_boot_archive_archive.py
What coverage did you get?
Some doc comments as to what these are actually doing would be nice.
line 249: It's commented out so this test really doesn't test anything?
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
