On 11/ 4/10 05:56 PM, Alok Aggarwal wrote:
Hi Dave,
Thanks for the review. Drew will be replying to
most of your comments, just a couple of comments below ..
On Mon, 25 Oct 2010, Dave Miner wrote:
distro_const/__init__.py: Much of this seems like stuff that would be
shared across apps using the DOC; is there a better way to implement
so that it can be shared?
Actually Darren just implemented CR 6996768 which
extends the DOC to take a module as input to register_class.
So, this code effectively becomes two lines:
for mod in [configuration, distro_spec, execution_checkpoint, transfer,
target]:
DataObjectCache.register_class(mod)
create_iso.py
-------------
97: Need comment here
171: can we either use a symlink or pass a reference to the correct
file via the DOC to create_usb so that we don't have an extra several
hundred MB of copied ISO around (and a simpler create_usb.py that
doesn't have to grope around trying to find its ISO)?
Yep, we can. I'll make it so.
pkg_img_mod.py, 173: sure we don't want to capture output to at least
the detailed log?
As an aside here, does it even make sense two have
two disparate log files per-build, a simple and a detailed
log. Who ever looks at the simple log?
This was originally modeled on nightly's behavior, with a summarized log
used for the mail message and the full log kept in the workspace.
Personally, I am usually looking primarily at the simple log, detailed
only when I don't see the problem immediately from it.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
