On Wed, 10 Nov 2010, Dave Miner wrote:
On 11/ 4/10 05:56 PM, Alok Aggarwal wrote:
Hi Dave,
Thanks for the review. Drew will be replying to
most of your comments, just a couple of comments below ..
On Mon, 25 Oct 2010, Dave Miner wrote:
pkg_img_mod.py, 173: sure we don't want to capture output to at least
the detailed log?
As an aside here, does it even make sense two have
two disparate log files per-build, a simple and a detailed
log. Who ever looks at the simple log?
This was originally modeled on nightly's behavior, with a summarized log used
for the mail message and the full log kept in the workspace.
Personally, I am usually looking primarily at the simple log, detailed only
when I don't see the problem immediately from it.
So, whatever gets logged to the simple_log also
gets logged to the screen; that's a little different
from the 'nightly' behavior which doesn't output anything
to the screen.
If there's a problem, you'd start by looking at the screen
output (which in most cases spans 2-3 screens).
Is that a good enough reason to do away with the simple log?
Less importantly, needing to maintain a single log file
simplifies the code substantially. We just use the default
file handler provided by the logger instead of defining
our own.
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
