On 11/ 4/10 09:56 PM, Alok Aggarwal wrote: > Hi Dave, > > Thanks for the review. Drew will be replying to > most of your comments, just a couple of comments > below .. > > On Mon, 25 Oct 2010, Dave Miner wrote: > >> distro_const/__init__.py: Much of this seems like stuff that would be shared >> across apps using the DOC; is there a better way to implement so that it can >> be shared? > > Actually Darren just implemented CR 6996768 which > extends the DOC to take a module as input to register_class. > So, this code effectively becomes two lines: > > for mod in [configuration, distro_spec, execution_checkpoint, transfer, > target]: > DataObjectCache.register_class(mod)
Actually, as previously mentioned, you probably shouldn't really be calling of register_class on transfer and target here, but instead fix them to do their own registration... Just saying, that's all... ;) Thanks, Darren. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
