On 11/24/10 03:38 AM, Darren Kenny wrote:
Hi Keith,
On 11/23/10 03:52 PM, Keith Mitchell wrote:
Hi Darren,
I like this class (needed something like it for the SCI tool). The code
looks good to me. Conceptually, would it be worthwhile to have
"TAG_NAME" be an abc.abstractproperty, rather than asserting on it in
the __init__ method? ("No" is a perfectly reasonable answer; I'm not
sure it's worth the effort myself...)
I can see where it could be useful, but I honestly think that it's more effort
for the amount of gain here - in fact it would make the sub-class a little less
straight forward since the it would require a new method rather than just a
simple variable assignment.
Thanks,
Darren.
Good point! Comment rescinded.
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
