On 12/31/10 05:55 AM, Jan Damborsky wrote:
Hi Dave,
thank you very much for review.
Please see my response in-line.
Jan
On 12/31/10 12:13 AM, Dave Miner wrote:
I lightly reviewed the non-UI portions:
On 12/14/10 10:00 AM, Jan Damborsky wrote:
...
Code review information
-----------------------
webrev:
http://cr.opensolaris.org/~kemitche/sci.1/
ip_address.py, 114: rather than "shorthand" you could use the proper
term, which is "prefix length" or "prefix". Obviously just a nit.
ok. I will change that.
system_info.py, 178: Please put a CR number for the RFE that needs to
be implemented here - which of course means file the RFE if it hasn't
been already.
I haven't found any CR which might cover that, so I have filed new one:
7009857 install needs API for obtaining current keyboard layout in form
of string
I will refer it in system_info.py.
user_info.py, 127: I'm wondering if we should leave uid unset and let
useradd do its own defaulting. The current behavior is perhaps OK in
installer cases, but for configuration it seems more likely to run
into conflicts.
That sounds reasonable. Based on your comment, do you think that we
should let useradd pick up default uid only
when SCI tool is invoked as a standalone application and configure it
explicitly in interactive installers ?
I think I'd just change it to let useradd determine the uid for all cases.
svc-system-config: What about fixing 7002621 while we're in here?
Sounds plausible. Let me take care of that.
users.py, 346: Do we really still need to restrict jack? I believe
the implementation should have been able to handle it once we
introduced the config service.
I agree. I will remove that code.
system-install-configuration.mf, 26: summary and description shouldn't
be equal; expand the description a bit.
Do you think that something like following might do the job ?
"This package contains libraries, Python modules and binaries used
by install technologies for core configuration of Solaris instance."
I'd drop the "This package contains" part and the rest would be OK.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
