I lightly reviewed the non-UI portions:
On 12/14/10 10:00 AM, Jan Damborsky wrote:
...
Code review information
-----------------------
webrev:
http://cr.opensolaris.org/~kemitche/sci.1/
ip_address.py, 114: rather than "shorthand" you could use the proper
term, which is "prefix length" or "prefix". Obviously just a nit.
system_info.py, 178: Please put a CR number for the RFE that needs to be
implemented here - which of course means file the RFE if it hasn't been
already.
user_info.py, 127: I'm wondering if we should leave uid unset and let
useradd do its own defaulting. The current behavior is perhaps OK in
installer cases, but for configuration it seems more likely to run into
conflicts.
svc-system-config: What about fixing 7002621 while we're in here?
users.py, 346: Do we really still need to restrict jack? I believe the
implementation should have been able to handle it once we introduced the
config service.
system-install-configuration.mf, 26: summary and description shouldn't
be equal; expand the description a bit.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
