On 01/03/11 17:05, Keith Mitchell wrote:
- Would it be useful to define a helper function for getting the
install profile obj so we don't have the exact same code all over
the place?
I understand that it is just 2 lines, but it would still be useful
to just make 1 change instead of 10+ changes, if something needs
to change.
Seems reasonable. I actually did just that for the ConfigProfile; no
reason the same couldn't be done here. Although I'd actually expect
the InstallProfile to disappear when the CUD/DOC 'target' objects
are used in text installer. so the long term value might be limited.
In the long term, I envision the CUD/DOC target objects will be used
for instantiating the target.
However, the values currently stored in the install profile is still
needed. For example, to
display the values in the Text Installer summary screen, and
possibility needed by the actual
installer application when it needs to set the timezone...etc..
Configuration is all stored in the ConfigProfile now; the only items
left in the InstallProfile is target related; the summary screens
could easily query against the target objects directly - I don't see a
need for the "InstallProfile" once the new target objects are used.
Ah, ok, for some reason, I kept thinking the config information is still
in the InstallProfile, and that's why
I thought it is still needed. You are right that once we convert the
Text Installer to using the CUD/DOC target objects,
we don't really need the InstallProfile anymore. So, it is up to you
whether you want to provide the helper function.
Thanks,
--Karen
(We can talk more tomorrow as well; I may be misunderstanding your point)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
