On 02/16/11 10:43 AM, William Schumann wrote:
To reviewers, thank you.
I have integrated some significant changes in two recent changesets:
- webserver design changes
- 7015429 Convert installadm.c to python
For the webserver changes:
I moved code formerly in my now defunct locate_profile.py to cgi_get_manifest.py
Modified ai_get_manifest.py to get:
- manifest
- any profiles
- any logging messages from the CGI that might be informative to the AI client
user on the console
Anyone familiar with webserver design changes, please check the above modules
for any incorrect assumptions.
I've not received any feedback on pyunit tests.
current webrev: http://cr.opensolaris.org/~wmsch/profile3/
differences with last webrev http://cr.opensolaris.org/~wmsch/profile2-diff/
last webrev: http://cr.opensolaris.org/~wmsch/profile2/
ai-webserver/Makefile, 87: had we previously discussed adding hostname
here? I'm concerned about diverging possible criteria between manifests
and profiles.
cgi_get_manifest.py
327: under what conditions do we run into a situation with criteria
missing? Does it happen when we're serving older clients? Just want to
understand if we're going to be generating a lot of noise here or not.
434: Why return this message to the client? There's nothing it can do
about it and really doesn't affect the validity of the profile from the
client's point of view.
export_profile.py, 120: s/delete/export/
ai_get_manifest.py, 49: now that we have build 159, /system/volatile
would be preferred. I presume we're going to let the upcoming AI->CUD
relocate the manifest.xml our of /tmp?
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
