Hi William,
I have re-reviewed client side:
auto_install.c
--------------
52: /var/run/profile -> /system/volatile/profile
ict.py
------
197: /var/run/profile -> /system/volatile/profile
1335: Since /etc/svc/profile/site.xml link is no longer created,
you also need to modify generate_sc_profile() ICT task (which
takes care of creating SC profile for interactive installers)
to drop resulting profile into /etc/svc/profile/site/ directory.
Jan
On 02/16/11 04:43 PM, William Schumann wrote:
To reviewers, thank you.
I have integrated some significant changes in two recent changesets:
- webserver design changes
- 7015429 Convert installadm.c to python
For the webserver changes:
I moved code formerly in my now defunct locate_profile.py to
cgi_get_manifest.py
Modified ai_get_manifest.py to get:
- manifest
- any profiles
- any logging messages from the CGI that might be informative to the
AI client user on the console
Anyone familiar with webserver design changes, please check the above
modules for any incorrect assumptions.
I've not received any feedback on pyunit tests.
current webrev: http://cr.opensolaris.org/~wmsch/profile3/
differences with last webrev
http://cr.opensolaris.org/~wmsch/profile2-diff/
last webrev: http://cr.opensolaris.org/~wmsch/profile2/
TODO: I'm still hanging onto code that extracts hostname and timezone
from profiles until which time I'm sure that its removal won't
interfere with testing.
On 01/28/11 12:23 AM, Dave Miner wrote:
... set_criteria.py
87: Perhaps add a "not both" to the end here to clarify slightly
(though, I wonder, would it be possible and useful to be able to do
both at once? seems convenient.)
Added support for both at once.
Thank you,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
