Hi Dermot, I've gone through the new diffs. Everything that you have fixed looks good to me with the exception of the V_ROOT tag at line 999 and one other thing that escaped me when I first reviewed the code:
579: partition.bootid = Partition.ACTIVE This is only applicable when the partition is a primary partition. If it is a logical partition then it can't be set to active. The Partition class has a method: change_bootid() that checks for this. Would it be better to use this method instead? Thanks, Niall -- This message posted from opensolaris.org _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
