On 06/05/2011 06:27, Niall Power wrote: > Hi Dermot, > > I've gone through the new diffs. Everything that you have fixed looks good to > me with the exception of the V_ROOT tag at line 999 and one other thing that > escaped me when I first reviewed the code: > > 579: partition.bootid = Partition.ACTIVE > This is only applicable when the partition is a primary partition. If it is > a logical partition then it can't be set to active. The Partition class has a > method: change_bootid() that checks for this. Would it be better to use this > method instead? Using that method has a side-effect I don't like - in that it removes the partition from the parent and re-inserts it.
If you don't have a parent - it fails - if you do, and you're looping through the parent's children, then the loop becomes unstable since you've changed this list part-way through... Darren. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
