Niall,
Thanks for the follow-up review.
Responses below.
On 05/06/11 06:27, Niall Power wrote:
Hi Dermot,
I've gone through the new diffs. Everything that you have fixed looks good to
me with the exception of the V_ROOT tag at line 999 and one other thing that
escaped me when I first reviewed the code:
This is fixed now - the tag is set to V_ROOT regardless
of arch.
579: partition.bootid = Partition.ACTIVE
This is only applicable when the partition is a primary partition. If it is
a logical partition then it can't be set to active. The Partition class has a
method: change_bootid() that checks for this. Would it be better to use this
method instead?
Given Darren's comments, I'm going to go with this for now:
change line 579 to:
if partition.is_primary:
partition.bootid = Partition.ACTIVE
if and when the issue with change_bootid() is resolved, we can change
to calling it, instead, which I agree would be preferable.
- Dermot
Thanks,
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
