Bill, Looks like a good, modest improvement to me.
I confirm that managing this log configuration file location in web.xml causes web.xml to be modified per-deployment in a way that's modestly inconvenient. cas.properties needs modified per-deployment anyway, so configuring the log configuration file location there sounds good. Andrew On Dec 29, 2011, at 1:09 PM, William G. Thompson, Jr. wrote: > Folks, > > This is a request for feedback regarding JIRA CAS-1082, Move Log4J > initialization into Spring bean config so that cas.properties can be > applied. - https://issues.jasig.org/browse/CAS-1082 > > Also see Pull Request: https://github.com/Jasig/cas/pull/22 > > I'm proposing this change be included in CAS 3.5 consistent with the > release strategy: > https://wiki.jasig.org/display/CAS/CAS+Roadmap > > Motivation for this change comes from working with over half a dozen > CAS deployments over the last year or so. > > This approach preserves the default location of > WEB-INF/classes/log4j.xml while making it very easy for deployers to > externalize the location via settings in cas.properties. This is > helpful in multi-node deployments, deployments across multiple tiers, > and preserving configuration between upgrades. > > A comparison of this patch against 3.4.11 showed no loss of logging. > > Best, > Bill > > -- > You are currently subscribed to [email protected] as: [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
