Bill, thanks for bringing the discussion to the list. What are the ramifications for people who upgrade their CAS version but had never before modified their log4j settings in the web.xml or for those who previously modified the web.xml?
Let's also be clear: this is an alternative to overriding the web.xml in your overlay. Both options provided the ability to do what you are saying can be done by moving these values to CAS.properties, though web.xml required copying the file to your overlay. I'm also interested in how you compared whether there was a loss of logging or not (I.e. is this initialized first so that if you set spring logging to debug, you will see all the startup debug messages?). Apologies if that was in the JIRA ticket. The emails are a pain to read on the phone. On Dec 29, 2011 1:10 PM, "William G. Thompson, Jr." <[email protected]> wrote: > Folks, > > This is a request for feedback regarding JIRA CAS-1082, Move Log4J > initialization into Spring bean config so that cas.properties can be > applied. - https://issues.jasig.org/browse/CAS-1082 > > Also see Pull Request: https://github.com/Jasig/cas/pull/22 > > I'm proposing this change be included in CAS 3.5 consistent with the > release strategy: > https://wiki.jasig.org/display/CAS/CAS+Roadmap > > Motivation for this change comes from working with over half a dozen > CAS deployments over the last year or so. > > This approach preserves the default location of > WEB-INF/classes/log4j.xml while making it very easy for deployers to > externalize the location via settings in cas.properties. This is > helpful in multi-node deployments, deployments across multiple tiers, > and preserving configuration between upgrades. > > A comparison of this patch against 3.4.11 showed no loss of logging. > > Best, > Bill > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
