Fix warning for usage of queue.size() in do_queues(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size().
warning from cppchecker was: [common/AsyncReserver.h:40]: (performance) Possible inefficient checking for 'queue' emptiness. Signed-off-by: Danny Al-Gaaf <[email protected]> --- src/common/AsyncReserver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/AsyncReserver.h b/src/common/AsyncReserver.h index 8cc2258..638bfb3 100644 --- a/src/common/AsyncReserver.h +++ b/src/common/AsyncReserver.h @@ -37,7 +37,7 @@ class AsyncReserver { void do_queues() { while (in_progress.size() < max_allowed && - queue.size()) { + !queue.empty()) { pair<T, Context*> p = queue.front(); queue_pointers.erase(p.first); queue.pop_front(); -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
