Fix warning for usage of *.size(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size().
warning from cppchecker was: [osd/OSD.h:265]: (performance) Possible inefficient checking for 'last_scrub_pg' emptiness. [osd/OSD.h:274]: (performance) Possible inefficient checking for 'last_scrub_pg' emptiness. Signed-off-by: Danny Al-Gaaf <[email protected]> --- src/osd/OSD.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/osd/OSD.h b/src/osd/OSD.h index b411c17..03d78cc 100644 --- a/src/osd/OSD.h +++ b/src/osd/OSD.h @@ -262,7 +262,7 @@ public: } bool first_scrub_stamp(pair<utime_t, pg_t> *out) { Mutex::Locker l(sched_scrub_lock); - if (last_scrub_pg.size() == 0) + if (last_scrub_pg.empty()) return false; set< pair<utime_t, pg_t> >::iterator iter = last_scrub_pg.begin(); *out = *iter; @@ -271,7 +271,7 @@ public: bool next_scrub_stamp(pair<utime_t, pg_t> next, pair<utime_t, pg_t> *out) { Mutex::Locker l(sched_scrub_lock); - if (last_scrub_pg.size() == 0) + if (last_scrub_pg.empty()) return false; set< pair<utime_t, pg_t> >::iterator iter = last_scrub_pg.lower_bound(next); if (iter == last_scrub_pg.end()) -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
