Fix warning for usage of objects.size(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size().
warning from cppchecker was: [osd/PG.h:599]: (performance) Possible inefficient checking for 'objects' emptiness. Signed-off-by: Danny Al-Gaaf <[email protected]> --- src/osd/PG.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/osd/PG.h b/src/osd/PG.h index ba80f81..3c95058 100644 --- a/src/osd/PG.h +++ b/src/osd/PG.h @@ -596,7 +596,7 @@ protected: /// Adjusts begin to the first object void trim() { - if (objects.size()) + if (!objects.empty()) begin = objects.begin()->first; else begin = end; -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
