Fix warning for usage of out->size() in _void_dequeue(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size().
warning from cppchecker was: [common/WorkQueue.h:97]: (performance) Possible inefficient checking for 'queue' emptiness. Signed-off-by: Danny Al-Gaaf <[email protected]> --- src/common/WorkQueue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/WorkQueue.h b/src/common/WorkQueue.h index b19a6a2..ced952c 100644 --- a/src/common/WorkQueue.h +++ b/src/common/WorkQueue.h @@ -94,7 +94,7 @@ public: void *_void_dequeue() { list<T*> *out(new list<T*>); _dequeue(out); - if (out->size()) { + if (!out->empty()) { return (void *)out; } else { delete out; -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
