HI Mikael,
On Jun 29, 2015, at 09:54 , Mikael Abrahamsson <[email protected]> wrote: > On Mon, 29 Jun 2015, Sebastian Moeller wrote: > >> Good work-around; not a real solution as sqm_logger() will also add >> "SQM:”. I think the solution most likely is to remove line 155 completely. >> But weirdly this seems to work with cerowrt… Correction, calling logger with an empty string works on cero (as well as on openwrt), but passing an empty string to sqm_logger results in the observed bug, so I can reproduce this locally. > > May I suggest a wrapper around the logger part that handles this case, ie if > the string is empty? Because when the string is empty and it gets stuck, luci > just waits and waits and waits. I mean, this specific case can be fixed, but > for the future it would be more robust if this error case can't happen at all. > > -- > Mikael Abrahamsson email: [email protected] I had a look at sqm_logger(): sqm_logger() { logger -t SQM -s ${1} } and hope that sqm_logger() { logger -t SQM -s "${1}” } Fixes the issue for me and is more concise than trying to introduce real error handling in sqm_logger. Does this also work for you? Best Regards Sebastian _______________________________________________ Cerowrt-devel mailing list [email protected] https://lists.bufferbloat.net/listinfo/cerowrt-devel
