On 03/09/2014 09:05 PM, Rafael Avila de Espindola wrote:


Sent from my iPhone

On Mar 9, 2014, at 13:05, Tobias Grosser <[email protected]> wrote:

On 03/09/2014 04:08 PM, Rafael Espíndola wrote:
The clang build has a CLANG_IS_PRODUCTION option. Historically this
would disable features that were not ready yet (c++ for example). It
would also disable plugins, which is an expensive feature for some
setups.

Currently the option is only used to disable plugins, so the attached
patch renames it to CLANG_NO_PLUGIN_SUPPORT.

What about using CLANG_PLUGIN_SUPPORT? This would avoid double negations.


While I also dislike double negations,
changing this one would make it default on (which is not ok) or require making 
it an actual configure option. would  that be better?

OK. If this is not obviously beneficial, I don't have any strong opinion here.


On the Makefile build it also enables dead stripping in plugins are
disabled. It looks like it was an oversight when dead stripping
support was added.

And just out of interest. Do you have an idea how much we loose in terms of 
start up performance, due to plugin support?


I don't have performance numbers at hand, but it is about 2mb of the final 
binary.

Thanks,
Tobias

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to