+1 to all of this. =] And to your thoughts about how to do the renaming Rafael. Generally, commit away, this looks like strict improvements.
On Mon, Mar 10, 2014 at 9:36 AM, Bob Wilson <[email protected]> wrote: > On Mar 10, 2014, at 6:38 AM, Tobias Grosser <[email protected]> wrote: > > > On 03/10/2014 02:35 PM, Rafael Espíndola wrote: > >>> OK. If this is not obviously beneficial, I don't have any strong > opinion > >>> here. > >> > >> Same here. It is quiet a bit more complicated and requires patching > >> llvm too, but it does avoid the double negation. Patches attached. > > > > Wow. I am impressed. Thanks Rafael for going through the trouble of > doing those patches. I think I prefer the new ones over what you proposed > before. > > I agree. This is much more clear than CLANG_IS_PRODUCTION. I recently came > across that build setting and had to dig around to see if it was still > being used for anything. I like this much better.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
