gamesh411 marked 7 inline comments as done.
gamesh411 added inline comments.
================
Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:5
+// RUN: cp "%S/Inputs/ctu-other.c" "%t/ctu-other.c"
+// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility
ctu-other.c","file":"ctu-other.c"}]' | sed -e 's/\\/\\\\/g' >
%t/compile_commands.json
+// RUN: cd "%t" && %clang_extdef_map ctu-other.c > externalDefMap.txt
----------------
martong wrote:
> Why do we need the `-Wno-visibility` flag?
Needed because the in-expression definition of a struct (which we cannot
import) also warrants a compiler warning, and this comes up 2 times even (once
when generating the extdef-mapping, second time when we analyze the file). Its
easier to handle this warning in the compilation database, as that removes both
occurrences of the warning.
================
Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:6
+// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility
ctu-other.c","file":"ctu-other.c"}]' | sed -e 's/\\/\\\\/g' >
%t/compile_commands.json
+// RUN: cd "%t" && %clang_extdef_map ctu-other.c > externalDefMap.txt
+// RUN: cd "%t" && %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only
-std=c89 -analyze \
----------------
martong wrote:
> If we execute `clang_extdef_map` then we don't need
> `Inputs/ctu-other.c[pp].externalDefMap.on-the-fly.txt` files. Do we?
Cannot remove as of yet, because they have .ast suffixed entries. In order to
remove them the whole logic of what should be inside the index
(externalDefMap.txt) for on-demand and non-on-demand cases should be discussed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75665/new/
https://reviews.llvm.org/D75665
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
