gamesh411 marked 5 inline comments as done. gamesh411 added inline comments.
================ Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:457 + return llvm::make_error<IndexError>( + index_error_code::ambiguous_compile_commands_database); + ---------------- martong wrote: > Could we have a lit test for this case? I.e having a compile_commands.json > with two ambiguous entries for the same file and then we should expect the > compiler diag? > (Note, I am asking this because it is not immediate for me from the code that > this will ever fire.) Good idea, I will create a standalone test case for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
