jkorous-apple added inline comments.

Comment at: clangd/Protocol.h:190
   /// (see exit notification) its process.
-  llvm::Optional<int> processId;
+  llvm::Optional<int> processId = 0;
Sorry if I am asking stupid question but since the type is Optional<> isn't 
it's default-constructed value more appropriate here?

Comment at: clangd/Protocol.h:211
   /// The initial trace setting. If omitted trace is disabled ('off').
-  llvm::Optional<TraceLevel> trace;
+  llvm::Optional<TraceLevel> trace = TraceLevel::Off;
Does it still make more sense to use Optional<TraceLevel> than plain TraceLevel?

  rCTE Clang Tools Extra


cfe-commits mailing list

Reply via email to