sammccall added inline comments.

Comment at: clangd/Protocol.h:80
 struct Position {
+  Position() = default;
+  Position(int line, int character) : line(line), character(character) {}
I'd lean to making callers initialize field-by-field here rather than provide 
It's not terrible here (you can get it wrong, but only one way), but it's a 
pattern that doesn't scale so well I think.

  rCTE Clang Tools Extra

cfe-commits mailing list

Reply via email to