On Mon, Feb 16, 2009 at 4:00 PM, Adam Langley <[email protected]> wrote: > On Mon, Feb 16, 2009 at 1:45 PM, Evan Martin <[email protected]> wrote: >> http://codereview.chromium.org/21401 does this. It seems to work on >> Windows (I'd like an expert to doublecheck I did it the right way) but >> my wild guess at making Mac work is apparently wrong. If any Mac >> expert could help out, I'd appreciate it. > > I support the idea of getting rid of build_config.h as an explicit > include. However, build_config.h defines more than just OS_XXX. Why > not pass "-include ../build/build_config.h" to GCC?
My reasoning was that we don't want to litter the preprocessor namespace with defines, and the OS_* ones are 99% of the reason to include the header. My (implied) plan was that build_config.h could become compiler_config.h or whatever once it's seen where it's needed. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
