Evan Martin wrote: >>> I agree with this in principle, but we're long past that, I think? >>> From one of the Mac build files:
We have to do that for WebKit because we use the set of FEATURE_DEFINES for more than just #defining macros. We also need to use them to drive code generation. In fact, this pattern does come up from time to time in third-party code which expects to have its build driven in such a way. In those cases, we do what we need to do to make the third-party code happy, but it's always restricted to the build for that module. We don't leak WebKit defines to parts of the build that don't care about WebKit, for example. In this specific case, there are a few things that have slipped into the list of FEATURE_DEFINES that don't belong there, probably out of nothing more than innocent ignorance. Fixing it's a low-priority cleanup task, and I might hit some of that as part of the build work I'm doing. Mark --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
