Nice work Stephen!!-Darin On Wed, May 13, 2009 at 9:03 AM, Stephen White <[email protected]>wrote:
> Ok, the Skia move is done. > I've had some reports that you need to clean/rebuild skia.lib, but that a > full clobber is not necessary. > > Thanks to maruel, thomasvl, and nsylvain for helping out with mop-up. > > Let me know if you have any further problems. > > Stephen > > On Tue, May 12, 2009 at 5:22 PM, Stephen White > <[email protected]>wrote: > >> I'm in the process of updating chromium to use tip-of-tree skia, and in >> the same CL, moving skia to a third_party directory, retrieved via DEPS. >> What this means for you: >> 1) Any outstanding CL's in which you've added #include >> "skia/include/..." will have to be changed to the corresponding >> path in "third_party/skia/include/..." (be warned that the subdirectory >> layout is also slightly different). >> 2) Going forward, any changes to skia will have to be done via commits to >> skia.googlecode.com, and then rolling DEPS in chromium (much the same as >> we now do for WebKit). >> 3) The new version of skia appears to render rects whose coordinates are >> "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There >> were a couple obvious instances of this in the code which I fixed, but there >> may be more. >> >> After this change, the local skia directory will contain only .gyp files, >> ext/ (chromium-specific skia utilities), and config/ (new >> directory, containing SkUserConfig.h). Everything else will live in >> third_party/skia. >> >> There were ~35 layout test failures due to minor pixel differences which I >> rebaselined on Windows and Linux, and 8 genuine failures related to masks >> and stroked text, which I have put in text_expectations.txt and assigned to >> myself. (There was another change which broke ~1700 tests on each platform, >> but I put that change behind an #ifdef for now). >> >> Unless I hear otherwise, I'm planning to do this Wednesday morning, 10AM >> EST (7AM PST). >> >> Stephen >> >> -- >> All truth passes through three stages. First, it is ridiculed. Second, it >> is violently opposed. Third, it is accepted as being self-evident. -- >> Schopenhauer >> > > > > -- > All truth passes through three stages. First, it is ridiculed. Second, it > is violently opposed. Third, it is accepted as being self-evident. -- > Schopenhauer > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
