On Wed, May 13, 2009 at 12:53 PM, Brett Wilson <bre...@chromium.org> wrote:
> On Wed, May 13, 2009 at 12:39 PM, Darin Fisher <da...@chromium.org> wrote:
> > That is what I meant by pain....
> > It only applies to "third party" code that conforms to the google style
> > guide, which says that all include paths must be relative to the root.
> Come
> > to think of it, I think this could cause problems for such projects,
> since
> > I'm sure the V8 developers don't think of V8 as a third party piece of
> code,
> > and in their world, V8 is not checked out into a directory named
> > third_party. We'd probably end up having to add "src/third_party" to the
> > include path or something like that.
>
> We already do this for all third_party code, but from chrome we
> include it with the third_party prefix. I think this is a good
> approach. In serverland, they actually change the includes in the
> third party files which I don't think we should do.
>
> Brett
>
This is fairly fragile. It doesn't work if header foo/A includes header
foo/bar/B. It works fine if foo/A includes bar/B, which is not the case for
a module "foo" that conforms to google style.
-Darin
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
