Can we put this in a bug for easier trackage? :DG<
On Mon, Jun 22, 2009 at 5:58 AM, Evan Martin<[email protected]> wrote: > > While we're wishing, I'll add that verifying this should be added to > the presubmit script (if you touched any layout tests). > > On Mon, Jun 22, 2009 at 3:20 AM, Dean McNamee<[email protected]> wrote: >> >> Last week I updated our DEPS to pull in a newer version of Skia. I >> was stumped at a few cases where the checked in PNG looked completely >> wrong, but yet it was passing on the buildbots. There was no way that >> image could have been the output. >> >> It just dawned on me today, but I haven't verified it. I can dig up >> my commit to verify it, but I'd say 99% sure this was the case. >> >> If the checksum is valid, we don't even go to the PNG. Therefor I >> believe we have a bunch of layout tests where the checked in PNG is >> completely wrong, but the checksum is right. >> >> I don't have the time right now, but it would be great if someone >> could write a script and clean this up. >> >> Thanks >> -- dean >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
