On Thu, Sep 10, 2009 at 11:05 AM, Jacob Mandelson <[email protected]> wrote:
> On Thu, Sep 10, 2009 at 10:03:00AM -0700, Dan Kegel wrote:
>> An external contributor was recently surprised that a change tested
>> on linux was reverted because it broke the build on windows.
>> (His mental model was that linux developers don't have to
>> worry about other platforms, that's what windows developers are for.)
>> He said that none of the doc at dev.chromium.org covered this, so I had a 
>> look.
>>
>
> It was more surprised that I was expected to have built chrome at home
> under multiple platforms.  I think most coders out there don't have
> set ups that let them build on all of the three.  Requiring that substantially
> restricts your contributor pool.  It's not an unreasonable policy, but it
> is an atypical one, so I think it should be spelled out in the
> "contributing" pages.

I don't think you are expected to have built and tested your change on
all three platforms.  The expectation is that your change will not
break any of the three platforms.

-scott

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected] 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to