On Fri, Sep 11, 2009 at 7:03 PM, Evan Martin <e...@chromium.org> wrote:
> I generally leave the "figure out the errors" bit to the committer.
I assume you mean the contributor. The problem is then that you are
trusting a non-committer to tell you whether to commit, which defeats
the purpose of having committer access.
>
> Once you've made sure a patch isn't malicious:
> git checkout origin
> git cl patch -b theirname 12345 # code review number
> git try
> git checkout branch_i_was_working_on
> You can then point them to the try server build page and say "search
> for your name for errors" if it fails.
>
> On Fri, Sep 11, 2009 at 6:58 PM, Evan Stade <est...@chromium.org> wrote:
>>
>> I agree it should be the responsibility of the committer to make sure
>> the code passes the trybots on all platforms (I have in the past made
>> the mistake of thinking the trybots were open to everyone, but they
>> are not). I think many committers will not be willing to go through
>> very many iterations of "download/apply patch, send to try bot, sort
>> out whether the errors are due to the patch, send errors back to
>> contributor", so non-committers will likely meet with difficulty when
>> trying to get patches in that they only tried on a single platform. So
>> I don't think it's necessarily a _requirement_ to have all three
>> platforms sitting around but having at least one windows and one posix
>> will greatly expedite the process.
>>
>> >>
>>
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
