Yea that already exists for "gcl" I don't know for "git-cl".

In a perfect world, I think we could do better, we should refactor the "gcl
try" code and make it even easier for us.

gcl try --issue 12345


That above syntax will grab the latest patch from that rietveld issue, email
who owns that issue, and send him/her the try results to their email in the
same time updating that rietveld try results online. The reason why we can't
do that approach is because we don't know the email, patch set. We can even
add optional overrideable parameters such as what exists right now (email,
patchurl, etc)

To implement that, we could edit our rietveld branch code and introduce an
easier way to fetch data, since the current way to fetch a description is by
requesting http://codereview.chromium.org/196105/description, it would be
cool if we could request info quickly as a json schema like
http://codereview.chromium.org/196105/info that way we can have information
such as "patch set", "email", "description", unless we parse it out directly
from the url.

But thats just in a perfect world.



- Mohamed Mansour


On Fri, Sep 11, 2009 at 10:20 PM, Evan Stade <[email protected]> wrote:

> On Fri, Sep 11, 2009 at 7:07 PM, Mohamed Mansour <[email protected]> wrote:
> > We could do this instead:
> > gcl try --url http://url/to/patch.diff --email [email protected]
> > --issue rietveldIssueNumber
> > No need to download and apply the patch.
> > - Mohamed Mansour
>
> heh, when I first read that I thought you were suggesting a new
> interface. But all those flags are already implemented. How
> convenient!
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected] 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to