On Sun, Sep 13, 2009 at 7:41 PM, Jeremy Orlow<[email protected]> wrote: > Unless we can get people upstream to compile with -Wall -Werror, that'll be > an uphill battle (every time we want to roll to a new version). It'd be > nice if we could, though.
Everyone should compile with -Wall -Werror, so it seems like a battle worth fighting :-) BTW, did you know what -Wall -W (but not -W -Wall) turns on yet more warnings? > > On Sun, Sep 13, 2009 at 11:35 AM, Ben Laurie <[email protected]> wrote: >> >> On Sun, Sep 13, 2009 at 7:13 PM, Darin Fisher<[email protected]> wrote: >> > I think no one has gone back and tried to build WebCore with -Werror >> > because >> > WebCore didn't used to build cleanly that way. It is also possible that >> > it >> > only had issues under MSVC, and then got lumped into the "external code" >> > bucket which disables a bunch of warnings. >> >> It doesn't build with gcc 4.3 + -Wall -Werror. >> >> But perhaps we should try to make it (and other third party libraries)? >> >> > -Darin >> > >> > On Sun, Sep 13, 2009 at 10:59 AM, Eric Seidel <[email protected]> >> > wrote: >> >> >> >> WebCore builds with -Werror upstream, so I'm slightly surprised that >> >> Chromium builds it w/ -Werror disabled. However it's possible we >> >> build with different errors turned on. >> >> >> >> -eric >> >> >> >> On Sun, Sep 13, 2009 at 10:27 AM, Ben Laurie <[email protected]> wrote: >> >> > >> >> > On Sun, Sep 13, 2009 at 6:14 PM, Craig >> >> > Schlenter<[email protected]> wrote: >> >> >> Hi Ben >> >> >> >> >> >> I think it's because webcore is not chromium_code. >> >> >> >> >> >> See build/external_code.gypi for where -Werror and -Wall are >> >> >> removed. >> >> > >> >> > Aha. How did I miss that? Thanks! >> >> > >> >> >> >> >> >> --Craig >> >> >> >> >> >> On Sun, Sep 13, 2009 at 7:10 PM, Ben Laurie <[email protected]> >> >> >> wrote: >> >> >>> >> >> >>> By default, cflags includes -Werror ... (see build/common.gypi). >> >> >>> >> >> >>> It seems something disables this for WebCore (which is built by >> >> >>> webkit/webkit.gyp:webcore) but I can't figure out what - does >> >> >>> anyone >> >> >>> know? >> >> >>> >> >> >>> >> >> >> >>> >> >> >> >> >> > >> >> > > >> >> > >> >> >> >> >> >> > >> > >> >> >> > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
