Eric Seidel wrote: > WebCore builds with -Werror upstream, so I'm slightly surprised that > Chromium builds it w/ -Werror disabled. However it's possible we > build with different errors turned on.
The last time I looked at this, our WebCore build throws warnings on four files on the Mac with GCC 4.2. They were silly namespace-visibility problems that could be fixed easily but at least in a couple of the cases, WebCore wasn't doing anything warning-worth and GCC was just being overzealous. I haven't looked at why they're not causing problems in the upstream WebCore build. Ben Laurie wrote: > BTW, did you know what -Wall -W (but not -W -Wall) turns on yet more > warnings? I did! Did you know that the new (better) name for -W is -Wextra? I looked at this too a while ago. The warnings at -Wall generally flag things that are likely to get you into trouble; the warning at -Wextra are more likely to flag things that CAN get you into trouble but don't usually. -Wextra threw up a number of warnings for our valid uses, and it didn't seem like it was worth the effort to fix them because there wasn't anything wrong with them in the first place. Mark --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
