Jeremy Orlow wrote: > Unless we can get people upstream to compile with -Wall -Werror, that'll be > an uphill battle (every time we want to roll to a new version). It'd be > nice if we could, though.
This is exactly the rationale for building code that's not our own with -Wall but not -Werror. We're not responsible for its maintenance, but we do want to know if it's doing things that smell suspicious, so that we can evaluate them and make the calls on whether they need attention ourselves. If we can get patches accepted upstream to fix warnings that occur in our builds, great. If not, I don't think it's worth burning our time by maintaining custom diffs that do nothing more than add some casts and parentheses just to make the build output from a third-party library prettier. Obviously, if a third-party library does something undesirable, whether or not it's exposed by a warning, it's worthwhile for us to patch it locally and pursue upstreaming the patch. Mark --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
