On Thu, Oct 8, 2009 at 10:44 AM, Mike Pinkerton <[email protected]>wrote:

> Wow, you guys are really on top of things :-) I think a half day is a
> bit too soon. Code reviews shouldn't be a priority 0 interrupt, even
> though they are quite important. I think it's ok to let it go a day or
> two before contacting, but I agree it's not rude to do so.


Ben's rule is "two hours".  Mine is "as soon as I notice your review", which
should hopefully be < 1 hr.

I would be really sad if my reviews normally took a half day for a response.
 I am frequently blocked on getting the CL in (usually not immediately, but
by the time several hours have passed), so delays that long really hinder my
workflow.  I encourage people to think of them as a P0 interrupt, except
maybe for poor souls like Darin who have a never-ending queue.

PK

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected] 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to