I routinely fail at providing timely reviews (sorry!), so I really appreciateit when people send pings through whatever mechanism.
-Darin On Thu, Oct 8, 2009 at 10:36 AM, Aaron Boodman <[email protected]> wrote: > > Lots of the engineers on Chromium aim to turn around code reviews in > hours. Some (like me) have even committed to making it more important > than their own work. It makes me sad when I find code reviews that > have been waiting for "lgtm" from me for weeks. > > If someone doesn't reply to your review or response within a half day, > you should definitely ping them. It isn't rude. It may have simply > slipped by, or there may be a misunderstanding about whose court the > ball is in. > > Also, I have noticed a convention developing where, when sending > reviews or responses, the target is pinged in irc. Like this: > aboodman: fyi: http://codereview.chromium.org/... > > I think this is totally awesome and encourage it, at least to me. > > Thanks, > > - a > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
