On Thu, Oct 8, 2009 at 10:44 AM, Mike Pinkerton <[email protected]> wrote: > On Thu, Oct 8, 2009 at 1:41 PM, Evan Martin <[email protected]> wrote: >> My rule, which I don't hold others to but instead try to lead by >> example, is 15 minutes after it has my attention (barring exceptional >> circumstances like a meeting, lunch, etc.). So please re-ping me if >> it takes longer than that. > > Wow, you guys are really on top of things :-) I think a half day is a > bit too soon. Code reviews shouldn't be a priority 0 interrupt, even > though they are quite important. I think it's ok to let it go a day or > two before contacting, but I agree it's not rude to do so.
My rationale is: someone sends me a code review when they think the code is "done", which means they're further along in their project than I am in mine, and I am now in the critical path for them making progress. But I can also see the other side. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
