Part of this has to do with your level of experience and how big the review is. Doing code reviews for people not yet up to speed is _painful_. And large reviews also can be. I think part of the reason things seem better to you is a reflection on your level of experience.
That said, some of us (me included!) should try to be better, even in these cases. On Oct 8, 2009 1:46 PM, "Mohamed Mansour" <[email protected]> wrote: Actually, Chromium has improved big time on the review rate. When I first started, some reviews usually stay unreviewed for more than a week, even repinging didn't work correctly :) But for the last couple of months, when I ask for a review, within the same hour I get a response, which is excellent. I don't even mind if its a day, but if its more than a day, it becomes unpleasant. It depends on the people you send the review ;x Its hard for "external" contributors to know who is on vacation while sending a review, so if they don't send a reply within a day, I assume they are on vacation, then I ask another person on irc for a review. I believe its getting better, better than when the project stated. There are still some people that once you give them a review, they forget about it and you look at their list of reviews, and they are too many. Some people tend to be busy with their important stuff, which is understandable, but 1 day over turn rate should be the maximum. -Mohamed On Thu, Oct 8, 2009 at 2:00 PM, Mike Pinkerton <[email protected]> wrote: > > > On Thu, Oct ... --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-de... --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
