Christoph Lameter wrote: > On Thu, 21 Sep 2006, Nick Piggin wrote: > > >>Patch 2/5 in this series provides hooks, and they are pretty unintrusive. > > > Ok. We shadow existing vm counters add stuff to the adress_space > structure. The task add / remove is duplicating what some of the cpuset > hooks do. That clearly shows that we are just duplicating functionality.
I don't think so. To start with, the point about containers is they are not per address_space. But secondly, these are hooks from the container subsystem into the mm subsystem. As such, they might do something a bit more or different than simple statistics, and we don't want to teach the core mm/ about what that might be. You also want to be able to configure them out entirely. I think it is fine to add some new hooks in fundamental (ie mm agnostic) points. Without getting to the fine details about exactly how the hooks are implemented, or what information needs to be tracked, I think we can say that they are not much burden for mm/ to bear (if they turn out to be usable). -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech
